-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix uncharge issue when force-deleting objects #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
changed the title
WIP: fix: fix uncharge issue when force-deleting objects
fix: fix uncharge issue when force-deleting objects
Apr 1, 2024
The e2e test failed. |
yutianwu
force-pushed
the
fix_force_delete
branch
from
April 2, 2024 02:19
18873a2
to
df3ca6f
Compare
yutianwu
force-pushed
the
fix_force_delete
branch
from
April 2, 2024 02:20
df3ca6f
to
113e610
Compare
keefel
reviewed
Apr 2, 2024
keefel
previously approved these changes
Apr 2, 2024
keefel
reviewed
Apr 2, 2024
keefel
approved these changes
Apr 2, 2024
forcodedancing
approved these changes
Apr 2, 2024
alexgao001
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will remove
MsgSetBucketFlowRateLimit
fromSerengeti
upgrade and fix the issue when force-deleting buckets.Rationale
Fix uncharge issue when force-deleting objects
Example
n/a
Changes
Notable changes:
MsgSetBucketFlowRateLimit
fromSerengeti
upgradePotential Impacts
n/a